Skip to content

scsi: reject truncated MODE SELECT parameter lists - #404

Merged
erichelgeson merged 1 commit into
mainfrom
eric/mode-select-paramlist
Aug 7, 2026
Merged

erichelgeson merged 1 commit into
mainfrom
eric/mode-select-paramlist

Conversation

@erichelgeson

Copy link
Copy Markdown
Contributor

A parameter list too short for the header, block descriptor or page it describes now returns PARAMETER LIST LENGTH ERROR per SCSI-2 8.2.8, instead of applying buffer contents the host never transferred.

A parameter list too short for the header, block descriptor or page it
describes now returns PARAMETER LIST LENGTH ERROR per SCSI-2 8.2.8,
instead of applying buffer contents the host never transferred.
@erichelgeson
erichelgeson marked this pull request as ready for review August 2, 2026 18:41
@github-actions

github-actions Bot commented Aug 2, 2026

Copy link
Copy Markdown

BlueSCSI Memory Report

Compared against release v2026.04.27

Memory Usage

Target FLASH RAM SCRATCH_X SCRATCH_Y
Pico_2_Audio_SPDIF 681.1 KB (+6.3 KB) [33%] 511.7 KB [100%] 3.5 KB [88%] 3.8 KB [94%]
Pico_2_DaynaPORT 673.4 KB (+6.3 KB) [33%] 511.7 KB [100%] 3.5 KB [88%] 3.0 KB [75%]
Pico_Audio_SPDIF 703.5 KB (+7.1 KB) [34%] 252.4 KB [99%] 1.5 KB [38%] 768 B [19%]
Pico_DaynaPORT 695.3 KB (+7.1 KB) [34%] 246.1 KB [96%] 1.5 KB [38%] —
Ultra 690.4 KB (+6.3 KB) [34%] 511.7 KB [100%] 3.5 KB [88%] 3.0 KB [75%]
Ultra_Wide 449.9 KB (+5.9 KB) [22%] 511.7 KB [100%] 2.0 KB [50%] 3.0 KB [75%]

Symbol Region Changes

Pico_Audio_SPDIF: 1 symbols moved RAM → FLASH (-96 B RAM)
Symbol Size
scsiDiskFolderIsTapeFolder(FsFile*) 96 B
Pico_DaynaPORT: 1 symbols moved RAM → FLASH (-96 B RAM)
Symbol Size
scsiDiskFolderIsTapeFolder(FsFile*) 96 B

@erichelgeson
erichelgeson merged commit 6ed1431 into main Aug 7, 2026
1 check passed
@erichelgeson
erichelgeson deleted the eric/mode-select-paramlist branch August 7, 2026 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant